Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BuildResidentialHPXML docs links, take 2 #1901

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

shorowit
Copy link
Contributor

Pull Request Description

We now automatically ensure the BuildResidentialHPXML measure.xml and README.md are updated when the OS-HPXML version is bumped. Previously we just tested for a problem on the CI and made a developer know they have to manually update the measure.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Dec 20, 2024
@shorowit
Copy link
Contributor Author

If you bump the version in HPXMLtoOpenStudio/resources/version.rb and then run openstudio tasks.rb update_measures, the BuildResidentialHPXML measure now updates.

Base automatically changed from whole-mf-bldg-zero-occupants to master December 20, 2024 20:10
Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach. And I can borrow this for ResStock, too.

@shorowit shorowit merged commit 34fce41 into master Dec 20, 2024
7 checks passed
@shorowit shorowit deleted the update_measure branch December 20, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants